Skip to content

Bump botocore dependency specification #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

jakob-keller
Copy link
Collaborator

@jakob-keller jakob-keller commented Feb 27, 2025

Description of Change

This PR intends to improve general compatibility of aiobotocore within the Python ecosystem by bumping the dependency specification of botocore, as well as boto3 and awscli.

Assumptions

Upstream diff contains several changes that require adjustments to the aiobotocore codebase.

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details): closes botocore 1.37.0 required for claude 3.7 #1306
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller added the dependencies Pull requests that update a dependency file label Feb 27, 2025
@jakob-keller jakob-keller self-assigned this Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 99.06977% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.62%. Comparing base (295cc41) to head (9090431).
Report is 36 commits behind head on master.

Files with missing lines Patch % Lines
aiobotocore/credentials.py 94.11% 1 Missing ⚠️
aiobotocore/session.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1307      +/-   ##
==========================================
+ Coverage   90.48%   90.62%   +0.14%     
==========================================
  Files          68       68              
  Lines        6336     6542     +206     
==========================================
+ Hits         5733     5929     +196     
- Misses        603      613      +10     
Flag Coverage Δ
unittests 90.62% <99.06%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jakob-keller jakob-keller force-pushed the bump-botocore branch 3 times, most recently from c72b9f8 to 81bc249 Compare February 28, 2025 15:35
@jakob-keller jakob-keller marked this pull request as ready for review February 28, 2025 15:45
@jakob-keller
Copy link
Collaborator Author

I'm bumping botocore up until 1.37.1 for now. 1.37.2 includes new serializers, which need more time for me to digest.

@jakob-keller
Copy link
Collaborator Author

With regards to test coverage: The two missing lines are also not tested in upstream, as far as I see it. Overall coverage was improved slightly.

@jakob-keller jakob-keller added this pull request to the merge queue Feb 28, 2025
Merged via the queue into aio-libs:master with commit 1a35466 Feb 28, 2025
18 checks passed
@jakob-keller jakob-keller deleted the bump-botocore branch February 28, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

botocore 1.37.0 required for claude 3.7
2 participants