Skip to content

Support custom ttl_dns_cache connector configuration #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jakob-keller
Copy link
Collaborator

Description of Change

Support custom ttl_dns_cache connector configuration.

Assumptions

None

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details): closes Allow passing ttl_dns_cache in connector_args #1258
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller added the enhancement New feature or request label Jan 19, 2025
@jakob-keller jakob-keller self-assigned this Jan 19, 2025
@jakob-keller jakob-keller force-pushed the allow_ttl_dns_cache_config branch from a92fe4d to d5001ed Compare January 19, 2025 10:18
@jakob-keller jakob-keller marked this pull request as ready for review January 19, 2025 10:20
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.53%. Comparing base (bdfbfd5) to head (c795b0c).
Report is 43 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1270      +/-   ##
==========================================
- Coverage   87.79%   87.53%   -0.26%     
==========================================
  Files          67       67              
  Lines        5905     5913       +8     
==========================================
- Hits         5184     5176       -8     
- Misses        721      737      +16     
Flag Coverage Δ
unittests 87.53% <100.00%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jakob-keller jakob-keller force-pushed the allow_ttl_dns_cache_config branch from d5001ed to c795b0c Compare January 19, 2025 10:59
@jakob-keller jakob-keller added this pull request to the merge queue Jan 19, 2025
Copy link
Collaborator

@thehesiod thehesiod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, this isn't doing anything with the param ;)

Copy link
Collaborator

@thehesiod thehesiod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, nevermind, see it now

Merged via the queue into aio-libs:master with commit 4e9869b Jan 19, 2025
12 checks passed
@jakob-keller jakob-keller deleted the allow_ttl_dns_cache_config branch January 19, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow passing ttl_dns_cache in connector_args
2 participants