-
Notifications
You must be signed in to change notification settings - Fork 21
Store already added node viewer and load it when needed #921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #921 +/- ##
==========================================
- Coverage 67.06% 66.92% -0.14%
==========================================
Files 51 51
Lines 4715 4726 +11
==========================================
+ Hits 3162 3163 +1
- Misses 1553 1563 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@superstar54 thank you for reopening this! It will greatly improve the usefulness of the lazy-loading work implemented in #802 w.r.t the results section. Will review ASAP! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! As stated, this will come in handy when node_view
s become MVCs. Good to not have to recreate them 🙂
Moving node view caching mechanism implemented by @superstar54 in the QE app (aiidalab/aiidalab-qe#921) into `AiidaNodeViewWidget`
Reopen PR #560 .
In aiidalab-widgets-base/viewer.py, it creates a new
viewer
every time we select a new AiiDA node, and the viewer is not saved in the app, so we can not reuse it later. This has two drawbacks:reset
.This PR stores the already added viewer and reuses it later.
This is also needed in the
lazy-loading
PR.