Feature Spin-Orbit coupling #708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @AndresOrtegaGuerrero, Thanks for the work! That's fast, and it's a very important feature. I will look at and test this PR. |
for more information, see https://pre-commit.ci
superstar54
requested changes
May 23, 2024
There was a problem hiding this comment.
Hi @AndresOrtegaGuerrero , thanks for the great work. Only a minor change is needed.
How would this PR affect the other plugins?
Comment on lines
214
to
216
| options=[ | ||
| ("W/o SOC", "wo_soc"), | ||
| ("SOC", "soc"), |
There was a problem hiding this comment.
I suggest using On and Off as options, just like Magnetism.
There was a problem hiding this comment.
@superstar54 like options=[
("Off", "wo_soc"),
("on", "soc"), ?
superstar54
reviewed
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #689