Skip to content

Conversation

edan-bainglass
Copy link
Member

This PR refactors the uploader widget to its own module and converts it to MVC. All is updated accordingly, including tests.

@edan-bainglass edan-bainglass force-pushed the redistribute-modules branch 2 times, most recently from cfe887f to 26f4708 Compare August 5, 2025 12:42
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

❌ Patch coverage is 92.45283% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.45%. Comparing base (e39dd4c) to head (1de6e6a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...p/configuration/advanced/pseudos/uploader/model.py 85.71% 5 Missing ⚠️
...lab_qe/app/configuration/advanced/pseudos/utils.py 88.57% 4 Missing ⚠️
...onfiguration/advanced/pseudos/uploader/uploader.py 95.38% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1359      +/-   ##
==========================================
+ Coverage   72.38%   72.45%   +0.07%     
==========================================
  Files          99      103       +4     
  Lines        7166     7188      +22     
==========================================
+ Hits         5187     5208      +21     
- Misses       1979     1980       +1     
Flag Coverage Δ
python-3.11 72.45% <92.45%> (+0.08%) ⬆️
python-3.9 72.47% <92.45%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@AndresOrtegaGuerrero AndresOrtegaGuerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@edan-bainglass edan-bainglass merged commit 9ba7557 into aiidalab:main Aug 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants