Skip to content

Conversation

AndresOrtegaGuerrero
Copy link
Member

This allows the PDOS plugin to use the custom NSCF k-point distance for display.

@AndresOrtegaGuerrero AndresOrtegaGuerrero marked this pull request as ready for review July 18, 2025 09:14
Copy link
Member

@edan-bainglass edan-bainglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Jul 18, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.28%. Comparing base (807ca9d) to head (ddd5768).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/aiidalab_qe/plugins/pdos/model.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1345   +/-   ##
=======================================
  Coverage   72.27%   72.28%           
=======================================
  Files          99       99           
  Lines        6892     6894    +2     
=======================================
+ Hits         4981     4983    +2     
  Misses       1911     1911           
Flag Coverage Δ
python-3.11 72.26% <90.00%> (+<0.01%) ⬆️
python-3.9 72.31% <90.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AndresOrtegaGuerrero AndresOrtegaGuerrero merged commit 1501425 into aiidalab:main Jul 18, 2025
9 checks passed
@AndresOrtegaGuerrero AndresOrtegaGuerrero deleted the nscf_kpoint_distance_fix branch July 18, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants