WIP: Move to Julia 1.3 and Zygote #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
the trainable issue could be solved like this: https://github.com/nmheim/GenerativeModels.jl/blob/ce9e6ecdcc0e7199e34211a1b44dd7a6f123613e/src/pdfs/abstract_pdfs.jl#L126-L129 @smidl @vitskvara @honzabim what do you think? |
nmheim
changed the title
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
===========================================
- Coverage 86.95% 75.24% -11.72%
===========================================
Files 11 13 +2
Lines 230 206 -24
===========================================
- Hits 200 155 -45
- Misses 30 51 +21
Continue to review full report at Codecov.
|
* use only first element of state as `observation` of state
- this fixes jacobian/@adjoint but does not generalize to
n-dimensional time series
* rename ode_decoder.jl -> ode_decoder_1dobs.jl
also turn of tests for detection of variance as this functionality will be removed soon.
This was referenced Oct 23, 2019
Closed
and re-enable other vae tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will need the following packages on master:
With Zygote we will loose the ability to specify trainable parameters of a model through
TrackedArrays. The replacement for this isFlux.trainablewhich we would have to overload for each typeTODO
@nogradfix might break some stuff inDistributions.jl. only apply it to the specific functions we need?useNoGradArrayStaticArrayin UnitVar CGaussian