Batch in rand as a kwarg?

[vitskvara]

What is the reason for batchsize in gaussian and cgaussian being a keyword argument? I would rather make it an optional positional one.

https://github.com/nmheim/GenerativeModels.jl/blob/59e8145e373ae18e9857ea1a50e050411026a19b/src/pdfs/gaussian.jl#L40-L44

[nmheim]

Just a personal preference of mine, if you like positional args better, please go ahead and change them :)

[vitskvara]

Also, maybe rename this to batchsize? I think of batch as a collection of batchsize samples.

[nmheim]

you have a point. as we are calling all the other lenghts xlength etc, should we go with batchlength or blength? I don't really like batchlength/blength though...

[vitskvara]

Me neither :) also, xlength and zlength are actually the dimensions of the space (number of rows), while batchsize is the number of samples (number of columns), so I feel it is ok.

[vitskvara]

I took the liberty and already incorporated this in the gan branch that is ready to be merged.

[nmheim]

closed with 426efc6