Skip to content

Conversation

Lancetnik
Copy link
Collaborator

@Lancetnik Lancetnik commented Aug 14, 2025

  1. deprecate LLMConfig.current, LLMConfig.default
  2. deprecate LLMConfig(config_list=[...])
  3. deprecate LLMConfig(**options)
  4. Add LLMConfig(*configs) API
  5. update all documentation, notebooks, tests, codebase deprecated features usages

All deprecations are scheduled for removal in v0.11.0 release

As a part of #1946
Closes #1412

@Lancetnik Lancetnik marked this pull request as draft August 14, 2025 17:19
@Lancetnik Lancetnik marked this pull request as ready for review August 20, 2025 19:52
@Lancetnik Lancetnik requested a review from marklysze August 20, 2025 19:53
@Lancetnik
Copy link
Collaborator Author

Lancetnik commented Aug 20, 2025

@marklysze probably, you can review just an autogen/ directory changes. All other stuff is just a deprecated syntax usages updates (in notebooks, documentation, tests, etc)

@qingyun-wu
Copy link
Collaborator

@marklysze will you review this PR?

@priyansh4320
Copy link
Collaborator

I have a concern about Doc Markdown breakage. Can you please confirm that markdowns aren't breaking?, due to changes , with a couple of screenshots in the description?
also can you please confirm if you have tested the docs by building and serving docs locally?

@Lancetnik
Copy link
Collaborator Author

I have a concern about Doc Markdown breakage. Can you please confirm that markdowns aren't breaking?, due to changes , with a couple of screenshots in the description? also can you please confirm if you have tested the docs by building and serving docs locally?

Снимок экрана 2025-08-25 в 20 15 28 Снимок экрана 2025-08-25 в 20 15 48 Снимок экрана 2025-08-25 в 20 14 56 Снимок экрана 2025-08-25 в 20 15 16

I didn't check all pages, but everything seems fine

Copy link

joggrbot bot commented Aug 25, 2025

📝 Documentation Analysis

All docs are up to date! 🎉


✅ Latest commit analyzed: aa626c3 | Powered by Joggr

@marklysze
Copy link
Collaborator

Thanks @Lancetnik, I'm good with this.

@sonichi as it's changing core LLMConfig please feel free to review if you want. Let's aim to merge by end of this week if no blockers.

@priyansh4320
Copy link
Collaborator

hey, @Lancetnik bro I am approving this as well

Copy link
Collaborator

@priyansh4320 priyansh4320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting changes. this branch needs a rebase.

@Lancetnik Lancetnik requested a review from priyansh4320 August 31, 2025 06:16
@marklysze marklysze enabled auto-merge September 4, 2025 19:13
@marklysze marklysze removed the request for review from sonichi September 4, 2025 19:14
@marklysze marklysze added this pull request to the merge queue Sep 4, 2025
Merged via the queue into main with commit d5a8bbc Sep 4, 2025
18 checks passed
@marklysze marklysze deleted the refactor/llmconfig-deprecations branch September 4, 2025 19:22
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 75.93985% with 32 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
autogen/mcp/mcp_proxy/operation_grouping.py 0.00% 24 Missing ⚠️
autogen/interop/pydantic_ai/pydantic_ai.py 0.00% 6 Missing ⚠️
autogen/llm_config/config.py 95.65% 1 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
autogen/agentchat/conversable_agent.py 63.69% <100.00%> (-1.69%) ⬇️
autogen/llm_config/entry.py 89.79% <100.00%> (-1.96%) ⬇️
autogen/llm_config/utils.py 100.00% <100.00%> (ø)
autogen/oai/client.py 56.56% <100.00%> (-3.83%) ⬇️
autogen/oai/openai_utils.py 62.97% <100.00%> (-2.91%) ⬇️
autogen/llm_config/config.py 91.93% <95.65%> (+3.84%) ⬆️
autogen/interop/pydantic_ai/pydantic_ai.py 41.79% <0.00%> (-1.29%) ⬇️
autogen/mcp/mcp_proxy/operation_grouping.py 35.21% <0.00%> (+1.42%) ⬆️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix usage of LLMConfig in notebooks
4 participants