-
Notifications
You must be signed in to change notification settings - Fork 459
refactor: deprecate LLMConfig contextmanager, .current, .default #2028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…2 into refactor/llmconfig-deprecations
…2 into refactor/llmconfig-deprecations
@marklysze probably, you can review just an |
@marklysze will you review this PR? |
I have a concern about Doc Markdown breakage. Can you please confirm that markdowns aren't breaking?, due to changes , with a couple of screenshots in the description? |
…2 into refactor/llmconfig-deprecations
Thanks @Lancetnik, I'm good with this. @sonichi as it's changing core LLMConfig please feel free to review if you want. Let's aim to merge by end of this week if no blockers. |
hey, @Lancetnik bro I am approving this as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requesting changes. this branch needs a rebase.
Codecov Report❌ Patch coverage is
... and 34 files with indirect coverage changes 🚀 New features to boost your workflow:
|
LLMConfig.current
,LLMConfig.default
LLMConfig(config_list=[...])
LLMConfig(**options)
LLMConfig(*configs)
APIAll deprecations are scheduled for removal in v0.11.0 release
As a part of #1946
Closes #1412