-
Notifications
You must be signed in to change notification settings - Fork 420
Fix swarm context variable function injection #1264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davorrunje
reviewed
Mar 10, 2025
davorrunje
approved these changes
Mar 10, 2025
Thanks! Co-authored-by: Davor Runje <[email protected]>
Codecov ReportAttention: Patch coverage is
... and 134 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Registering functions on an agent that goes into a swarm has different implementations based on whether you use the agent's
functions
parameter when creating or theregister_for_llm
decorator. This can cause issues in that using thefunctions
parameter does not create aTool
as such, exceptions were being raised.This aligns them so they both end up creating a Tool and have simplified the approach to hiding parameters on tool schemas for LLMs (essentially uses the same as Dependency Injection).
Related issue number
Closes #1157
Checks