Fix the helm test #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afrittoli
force-pushed
the
kind_test
branch
3 times, most recently
from
0296455 to
14ba171
Compare
afrittoli
force-pushed
the
kind_test
branch
2 times, most recently
from
e35327f to
d363e80
Compare
The helm test relies on the KO_DOCKER_REPO variable, which won't work as it points to kind.local. Change the helm test to use a registry local to the namespace, similar to what the kaniko test does. Signed-off-by: Andrea Frittoli <[email protected]>
afrittoli
pushed a commit
that referenced
this pull request
Aug 9, 2022
Required fields and related webhook validations are added to support a user to configure compute resources for TaskRun which will significantly reduce the over-asked resources amount configured by the Step-level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The helm test relies on the KO_DOCKER_REPO variable, which won't
work as it points to kind.local.
Change the helm test to use a registry local to the namespace,
similar to what the kaniko test does.
Signed-off-by: Andrea Frittoli [email protected]
/kind feature
Supported kinds are: bug, cleanup, design, documentation, feature, flake, misc, question, tep
-->
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes