Skip to content

AYS-683 | Changed 404 'NOT_FOUND' error to 'NOT_EXIST_ERROR' and updated header message to 'NOT EXIST ERROR' #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2025
Merged

AYS-683 | Changed 404 'NOT_FOUND' error to 'NOT_EXIST_ERROR' and updated header message to 'NOT EXIST ERROR' #441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c0fb35
AYS-683| 404 Not Found Error Header Changed to 'NOT EXIST ERROR' from…
yagmurbarank Feb 3, 2025
3af3ce0
AYS-683 | Changed 404 'NOT_FOUND' error to 'NOT_EXIST_ERROR' and upda…
yagmurbarank Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/ays/common/exception/handler/GlobalExceptionHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ AysErrorResponse handleNotExistError(final AysNotExistException exception) {
log.error(exception.getMessage(), exception);

return AysErrorResponse.builder()
.header(AysErrorResponse.Header.NOT_FOUND.getName())
.header(AysErrorResponse.Header.NOT_EXIST_ERROR.getName())
.message(exception.getMessage())
.build();
}
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/ays/common/model/response/AysErrorResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public enum Header {
/**
* NOT_FOUND header.
*/
NOT_FOUND("NOT EXIST"),
NOT_EXIST_ERROR("NOT EXIST ERROR"),
/**
* VALIDATION_ERROR header.
*/
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/org/ays/auth/controller/AdminRegistrationApplicationEndToEndTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,7 +612,7 @@ void givenValidAdminRegistrationApplicationId_whenApproveAdminRegistrationApplic
MockHttpServletRequestBuilder mockHttpServletRequestBuilder = AysMockMvcRequestBuilders
.post(endpoint, superAdminToken.getAccessToken());

AysErrorResponse mockErrorResponse = AysErrorResponseBuilder.NOT_FOUND;
AysErrorResponse mockErrorResponse = AysErrorResponseBuilder.NOT_EXIST_ERROR;

aysMockMvc.perform(mockHttpServletRequestBuilder, mockErrorResponse)
.andExpect(AysMockResultMatchersBuilders.status()
Expand Down Expand Up @@ -840,7 +840,7 @@ void givenValidAdminRegistrationApplicationRejectRequest_whenRejectAdminRegistra
MockHttpServletRequestBuilder mockHttpServletRequestBuilder = AysMockMvcRequestBuilders
.post(endpoint, superAdminToken.getAccessToken(), rejectRequest);

AysErrorResponse mockErrorResponse = AysErrorResponseBuilder.NOT_FOUND;
AysErrorResponse mockErrorResponse = AysErrorResponseBuilder.NOT_EXIST_ERROR;

aysMockMvc.perform(mockHttpServletRequestBuilder, mockErrorResponse)
.andExpect(AysMockResultMatchersBuilders.status()
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/ays/common/exception/handler/GlobalExceptionHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ public String getMessage() {

// When
AysErrorResponse mockErrorResponse = AysErrorResponse.builder()
.header(AysErrorResponse.Header.NOT_FOUND.getName())
.header(AysErrorResponse.Header.NOT_EXIST_ERROR.getName())
.message(mockException.getMessage())
.build();

Expand Down
4 changes: 2 additions & 2 deletions src/test/java/org/ays/common/model/response/AysErrorResponseBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ public class AysErrorResponseBuilder {
.header(AysErrorResponse.Header.CONFLICT_ERROR.getName())
.isSuccess(false).build();

public static final AysErrorResponse NOT_FOUND = AysErrorResponse.builder()
.header(AysErrorResponse.Header.NOT_FOUND.getName())
public static final AysErrorResponse NOT_EXIST_ERROR = AysErrorResponse.builder()
.header(AysErrorResponse.Header.NOT_EXIST_ERROR.getName())
.isSuccess(false).build();

}