Skip to content

Conversation

agitrubard
Copy link
Collaborator

@agitrubard agitrubard commented Jun 23, 2024

Checklist

Before submitting your pull request, ensure the following:

  • Title and Branch Naming Conventions:

  • Local Testing:

    • I have tested my changes locally on Postman, and they are working as expected.
  • Code Quality:

    • The code is formatted according to the project's coding guidelines and style.
    • The code has been reviewed to ensure its quality.
    • The code does not contain any issues flagged by SonarLint.
  • Documentation:

    • Necessary documentation has been added or existing documentation has been updated, specifically detailing changes made in Postman.
  • Testing:

    • Relevant unit tests have been written and included.
    • Relevant integration tests have been written and included.
  • Reviewers and Assignees:

    • Default reviewers have been assigned to this pull request.
    • Assignees have been added if necessary.
  • Labels and Associations:

    • No specific actions are required in the Labels and Associations section for this pull request.

# Conflicts:
#	src/test/java/org/ays/emergency_application/controller/EmergencyEvacuationApplicationControllerTest.java
#	src/test/java/org/ays/emergency_application/controller/EmergencyEvacuationApplicationSystemTest.java
…nRepository` and Method Has Been Added to `InstitutionAdapter`
…Moved to `emergency_application.model` Package
… Moved to `emergency_application.model` Package
…Been Updated, Unnecessary Codes Have Been Removed, Port/Adapter Layer Has Been Integrated and All Tests Have Been Refactored
@agitrubard agitrubard requested a review from skayikci as a code owner June 23, 2024 14:05
@agitrubard agitrubard changed the title Refactor/ays 275 package AYS | Project Package/Layer/Infrastructure Renew Jun 23, 2024
…Been Moved to `test/emergency_application/model` Package
… Been Moved to `test/emergency_application/model` Package
…s Been Moved to `test/emergency_application/model/request` Package
@agitrubard agitrubard merged commit 344f11d into main Jun 24, 2024
@agitrubard agitrubard deleted the refactor/AYS-275_package branch June 24, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant