Skip to content

Conversation

agitrubard
Copy link
Collaborator

@agitrubard agitrubard commented May 16, 2024

Checklist

Before submitting your pull request, ensure the following:

  • Title and Branch Naming Conventions:

  • Local Testing:

    • I have tested my changes locally on Postman, and they are working as expected.
  • Code Quality:

    • The code is formatted according to the project's coding guidelines and style.
    • The code has been reviewed to ensure its quality.
    • The code does not contain any issues flagged by SonarLint.
  • Documentation:

    • Necessary documentation has been added or existing documentation has been updated, specifically detailing changes
      made in Postman.
  • Testing:

    • Relevant unit tests have been written and included.
    • Relevant integration tests have been written and included.
  • Reviewers and Assignees:

    • Default reviewers have been assigned to this pull request.
    • Assignees have been added if necessary.
  • Labels and Associations:

    • No specific actions are required in the Labels and Associations section for this pull request.

agitrubard added 30 commits May 13, 2024 22:52
…named as `AdminRegistrationApplicationCompleteRequest`
…s Been Renamed as `AysAdminRegistrationApplicationNotExistByIdException`
…lass Has Been Renamed as `AysAdminRegistrationApplicationSummaryNotExistByIdException`
…lass Has Been Renamed as `AysAdminRegistrationApplicationSummaryNotExistByIdException`
…s Been Renamed as `AysAdminRegistrationApplicationNotExistByIdException`
…xception` Class Has Been Renamed as `AysAdminRegistrationApplicationNotExistByIdOrStatusNotWaitingException`
…d as `AdminRegistrationApplicationListRequest`
… as `AdminRegistrationApplicationRepository`
…amed as `AdminRegistrationApplicationCreateResponse`
…named as `AdminRegistrationApplicationSummaryResponse`
…med as `AdminUserRegistrationApplicationsResponse`
…Renamed as `AdminRegistrationApplicationsResponse`
…med as `AdminRegistrationApplicationRejectRequest`
… `AdminRegistrationApplicationService` and Java DOCs Have Been Refactored
Copy link

@Furkan-Ahmet-Ozdemir Furkan-Ahmet-Ozdemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

MenekseYuncu
MenekseYuncu previously approved these changes May 17, 2024
Copy link
Contributor

@MenekseYuncu MenekseYuncu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eline sağlık

…` Class Has Been Changed as `package-private`
MenekseYuncu
MenekseYuncu previously approved these changes May 17, 2024
moaydogdu
moaydogdu previously approved these changes May 18, 2024
@agitrubard agitrubard dismissed stale reviews from moaydogdu and MenekseYuncu via 1a2f689 May 19, 2024 11:45
@agitrubard agitrubard requested a review from moaydogdu May 19, 2024 11:45
@skayikci
Copy link
Collaborator

TESEKKURLER!

@agitrubard agitrubard merged commit fbad5ec into main May 20, 2024
@agitrubard agitrubard deleted the feature/AYS-246_registration-application branch May 20, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants