-
Notifications
You must be signed in to change notification settings - Fork 0
FMWK-850 Fix in-doubt counter for bacth writes #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
filkeith
commented
Nov 11, 2025
- count in-doubt for batch operations
- count in-doubt for batch operations
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
==========================================
- Coverage 81.16% 81.08% -0.08%
==========================================
Files 109 109
Lines 8378 8392 +14
==========================================
+ Hits 6800 6805 +5
- Misses 1083 1087 +4
- Partials 495 500 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- removed batch inDoubt logging
- debug
- testing
- log all in-doubt errors
io/aerospike/record_batch_writer.go
Outdated
| // processOperationResult increases statistics counters. | ||
| // it returns true if operation should be retried. | ||
| func (rw *batchRecordWriter) processOperationResult(op a.BatchRecordIfc) bool { | ||
| if op.BatchRec().Err != nil && op.BatchRec().Err.IsInDoubt() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 139-141:
if aerr != nil && aerr.IsInDoubt() {
rw.stats.IncrErrorsInDoubt()
}should be removed, as the counter is per record.
- async batch calculation