Skip to content

Conversation

@filkeith
Copy link
Contributor

  • count in-doubt for batch operations

- count in-doubt for batch operations
@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 95.23810% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.08%. Comparing base (e315dab) to head (845d4fc).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
io/aerospike/record_batch_writer.go 95.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
- Coverage   81.16%   81.08%   -0.08%     
==========================================
  Files         109      109              
  Lines        8378     8392      +14     
==========================================
+ Hits         6800     6805       +5     
- Misses       1083     1087       +4     
- Partials      495      500       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- removed batch inDoubt logging
- log all in-doubt errors
@filkeith filkeith marked this pull request as ready for review November 12, 2025 12:43
// processOperationResult increases statistics counters.
// it returns true if operation should be retried.
func (rw *batchRecordWriter) processOperationResult(op a.BatchRecordIfc) bool {
if op.BatchRec().Err != nil && op.BatchRec().Err.IsInDoubt() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 139-141:

if aerr != nil && aerr.IsInDoubt() {
	rw.stats.IncrErrorsInDoubt()
}

should be removed, as the counter is per record.

- async batch calculation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants