Feature: Digit Formats #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created separator prefab, created digit separator class. - I've broken functionality in regards to digit selection, we'll have to address in a future commit but for the most part, the core logic for digits has been moved to it's own class instead of living in the main class. We'll still have to work on improving readability and reworking a couple questionable methods (probably those related to our enums)
We've changed the flow and layout a bit so it'd be wise to take another look at this from top to bottom to understand how the application is currently running. Almost done with the refactor, have a couple bugs to still iron out but should be working for the most part using different formats too! :D
This is because when the timer is running, it's constantly spamming the animation which hides the values from view. The tick animation is intended for seconds and upwards since those will tick less and not as frequently
This way we can invoke the regeneration via context menu too
Arrow keys (Horizontal Input) works again with nothing / everything selected
Since we have a method as well called 'SetTextColor'
adrian-miasik
force-pushed
the
feature/digit-formats
branch
from
ca8cca3 to
2a17cd5
Compare
adrian-miasik
force-pushed
the
feature/digit-formats
branch
from
5aee08c to
fc9fb04
Compare
Merged
adrian-miasik
added
2. Priority: High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions
DigitSeparator.csSeparator.prefabDigitFormat.csDD_HH_MM_SS_MS- FullHH_MM_SS_MS- DetailHH_MM_SS- Default / StandardMM_SS- SimpleSS- BareHotkeyDetector.csF1swaps digit format to FullF2swaps digit format to DetailF3swaps digit format to Default / StandardF4swaps digit format to SimpleF5swaps digit format to BareInformationPanel.csto only update it's color components when visibleRefactors
PomodoroTimer.csDoubleDigit.csPomodoroTimer.cstoDigitFormat.csCoding Style
BooleanToggleEditor.csto follow our coding style