-
-
Notifications
You must be signed in to change notification settings - Fork 116
Update README.md with release time process doc #834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Andrew Leonard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw.
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
sxa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not personally going to approve this but others can if they so desire. This is adding an extra section with similar instructions about how the process works and the new section still requires you to look at the other section to know how to do the required bits so you have to bounce around if you look at the new instructions and this introduces a certain amount of duplication which risks things getting out of sync.
My preference would be to update the existing section in this document if it's unclear with additional points for clarity and/or put a terse version of this in the releasing guide.
|
/merge |
|
Approval to merge during the lockdown cycle Please can two Adoptium PMC members comment |
Code freeze removed
Signed-off-by: Andrew Leonard <[email protected]>
sxa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My previous review still stands. Figuring out the process now involves bouncing around the document with separate sections instead of trying to make the existing sections clearer, but I won't block it.
Add a verbose section on how to process dockerhub images at release time, and a general basic explanation of how it works for newbies...
Fixes #382