Skip to content

Conversation

@andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard commented Oct 29, 2025

Add a verbose section on how to process dockerhub images at release time, and a general basic explanation of how it works for newbies...

Fixes #382

@andrew-m-leonard andrew-m-leonard self-assigned this Oct 29, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

@andrew-m-leonard andrew-m-leonard requested a review from sxa October 29, 2025 14:30
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not personally going to approve this but others can if they so desire. This is adding an extra section with similar instructions about how the process works and the new section still requires you to look at the other section to know how to do the required bits so you have to bounce around if you look at the new instructions and this introduces a certain amount of duplication which risks things getting out of sync.

My preference would be to update the existing section in this document if it's unclear with additional points for clarity and/or put a terse version of this in the releasing guide.

@andrew-m-leonard
Copy link
Contributor Author

/merge

@github-actions
Copy link
Contributor

Approval to merge during the lockdown cycle

Please can two Adoptium PMC members comment /approve?

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My previous review still stands. Figuring out the process now involves bouncing around the document with separate sections instead of trying to make the existing sections clearer, but I won't block it.

@andrew-m-leonard andrew-m-leonard merged commit 7bdbab4 into adoptium:main Nov 7, 2025
96 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need explicit doc description of what's required to update dockhub during a release

4 participants