feat(geo-brand-presence): add auto-routing based on Configuration #1472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add per-site Configuration check for geo-brand-presence-daily enablement - Implement 4-level priority for cadence determination: 1. Explicit context override (for testing/wrappers) 2. Per-site Configuration check (NEW) 3. Site-specific config (backward compatibility) 4. Default to weekly - Route to refresh:geo-brand-presence-daily or refresh:geo-brand-presence accordingly - Enhance logging to show Configuration status and determined cadence - Add comprehensive JSDoc documentation This allows automatic routing based on which audit is enabled for the site, matching patterns used in llmo-customer-analysis and cdn-analysis handlers.
- Add automatic cadence detection based on entitlements and config - Support both daily and weekly routing from single handler - Update tests with proper Configuration and TierClient mocks - Add cadence field to audit results for tracking Priority for cadence determination: 1. Explicit context.brandPresenceCadence override 2. Per-site Configuration check (isAuditEnabledForSite) 3. Site config (getBrandPresenceCadence) 4. Default to weekly
|
This PR will trigger a minor release when merged. |
The 200-prompt hard limit was removed in main branch (commit 5ee15d7). Updated tests to expect all prompts to be included without limit. Changes: - Update 'should prioritize customer prompts' test to expect 225 prompts (was 200) - Update 'should use only customer prompts' test to expect 300 prompts (was 200) - Remove 'EXCLUDE_FROM_HARD_LIMIT' test as that logic no longer exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements automatic routing for the
refresh:geo-brand-presencehandler based on per-site Configuration enablement.Changes
geo-brand-presence-dailyis enabled for a siterefresh:geo-brand-presence-dailyorrefresh:geo-brand-presenceaccordinglyHow it works
The handler now checks (in order):
Testing
Related
Follows pattern from
llmo-customer-analysis(line 151) andcdn-analysishandlers.