Skip to content

Conversation

nwidynski
Copy link
Contributor

@nwidynski nwidynski commented Mar 5, 2025

Found in testing. Seem to have slipped in without any use?

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems to have been a carry over from when we only had Datepicker props as a base prop, thanks for the catch!

@LFDanLu LFDanLu added this pull request to the merge queue Mar 5, 2025
Merged via the queue into adobe:main with commit cce5fd3 Mar 5, 2025
31 checks passed
@nwidynski nwidynski deleted the fix-datefield-overlay branch March 5, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants