Skip to content

Conversation

@ravuthu
Copy link
Contributor

@ravuthu ravuthu commented Nov 21, 2025

Showing a toolbar when selecting the copy text might be convenient for authors to edit content

#658

Motivation and Context

I was authoring a block that had around 20 cards, and each card had an H3. Clicking on the edit link was an additional effort that I had to put in every time I format H3. Having a floating toolbar would solve that, IMHO.

How Has This Been Tested?

Initialized the localhost and tested it on http://localhost:3000/edit#/aem-sandbox/block-collection/aclarke. Made sure that it will be hidden when selecting an option or clicking outside the toolbar, etc. It will not be shown when the user selects a link or an image. I verified the feature on mobile also.

Screenshots (if appropriate):

Screenshot 2025-11-21 at 9 37 12 AM
Edit.aclarke.-.DA.webm

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@auniverseaway
Copy link
Member

I think this is really interesting. It makes me feel a bit uncomfortable, but I do think its great research.

I always think about, "The Windows 98 problem" which is... having many different ways (or UX patterns) to do the same task. It becomes a support nightmare and confusing for practitioners. If you look at the screenshot below, how many ways can you open up Internet Explorer? 3. That's three ways they had to document, write code around, etc.

Having another toolbar... in addition to the slash menu (which is already another UX), means we have another place to do all our menu updates and we have more documentation to write, etc. Again, same problem as Windows 98 and we're only a lowly editor.

I'm tempted to say, "if we ship this toolbar... can we remove it from the side menu?" I'm not sure if this is even a good idea. You're on an empty line and what do you do?

For now, I would opt to say, "let's increase our keyboard shortcut footprint" over shipping another UX paradigm. If we see that this crops up as an issue for more users, we have this in our pocket.

I would also say I'm still not opposed to popping out the existing menu without the main menu labels. This would be a nice middle ground and solves some of the issues I mention above.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants