-
Notifications
You must be signed in to change notification settings - Fork 54
feat: use media route #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
I really like this, but its probably something we should do during the Helix6 / DA2 cycle... I get the problem at hand, so if we cannot come up with a solution with fewer tradeoffs, we should carry this out. I know why it needs to exist, but creating a media route seems needlessly tedious to the API consumer. A developer should be able to upload to source and we figure it out where it needs to go. We know what the mime type is so we know if it should go to Media Bus. I don't want us in the same mess as Content Bus / Media Bus where something can live in either place (ala SVG). There should be one code path to get a source file into DA and we decide where it needs to live in the repository. This obviously works where we do not care where these files live, but it also creates a fork in implementations where if I upload a file direct (drag and drop in browse), its a different code path... these are back to living in DA. I would like us to use Media Bus e2e if we're going to use Media Bus as our asset store. Potential paths forward
|
|
We can definitively think the "API routes" differently. Side note: |
Use the new
/mediaroute - see adobe/da-admin#178Note: only merge this one when adobe/da-admin#178 has been deployed to production.
Test: https://media--da-live--adobe.aem.live/?da-admin=stage
UX in case of error (like if image is > 20MB) needs to be reviewed.