New FileSystem API #5797
New FileSystem API #5797
Conversation
|
All changes from the review comments pushed. |
… projectFilesChanged event
src/filesystem/File.js
Outdated
There was a problem hiding this comment.
@iwehrman I'd rather us not do a catch-and-log if we don't need to, since it breaks the debugger "break on uncaught exceptions" feature. In this case it seems unneeded since the only thing that comes afterward is in a finally block anyway.
There was a problem hiding this comment.
I forgot about the "break on uncaught exceptions" use case. I'll change all these try-catch-finally blocks in which the catch only contains a console.warn to just try-finally blocks.
|
Sorry for adding a bunch of comments saying I was fixing stuff that's already been fixed... dunno how I got so far out of sync from the tip of the branch. One of my |
|
Holy crap, it's actually ready to land. Here goes nothing! 🙈 🙏 |
|
Oh man... Let's see how this one breaks my extensions 🎲 |
|
Boom! The eagle has landed! |
|
|
|
High five, Ian! 🙌 |
|
|
|
|
|
|
This pull request adds a new FileSystem API that replaces
NativeFileSystem,FileIndexManagerand direct calls tobrackets.fs.*functions.This pull request changes the API, but does not add any significant new features or performance gains. These will be done in subsequent pull requests.
This is a big change. It will break some extensions. However, the breakages are minimized through deprecation "shims" for many of the commonly used APIs that have been removed.
See this Brackets-Dev forum thread for an introduction to the changes.
See the FileSystem and FileSystem API Migration wiki pages for more details.
Sign-offs: