fix(download-logs): retry download logs fixes #711 #712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proactivebit
force-pushed
the
issue/download-logs-connection-reset
branch
5 times, most recently
from
f876aab to
8378039
Compare
marcin2357
reviewed
Jun 26, 2025
test/cloudmanager-helpers.test.js
Outdated
| jest.restoreAllMocks() | ||
| }) | ||
|
|
||
| test('should not retry function succeed', async () => { |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
proactivebit
force-pushed
the
issue/download-logs-connection-reset
branch
from
8378039 to
efb6789
Compare
marcin2357
approved these changes
Jun 26, 2025
|
🎉 This PR is included in version 4.2.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add retry mechanism in case connection reset
Related Issue
711
Motivation and Context
download log operation should run with no interruption
How Has This Been Tested?
Unit tests, regression tests
Screenshots (if appropriate):
Types of changes
Checklist: