-
Notifications
You must be signed in to change notification settings - Fork 762
SITES-22935 NGDM remote image issue #2792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Make changes work for multiple fileupload instances present in a custom multifield component.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
...t/src/content/jcr_root/apps/core/wcm/components/image/v3/image/clientlibs/editor/js/image.js
Outdated
Show resolved
Hide resolved
...t/src/content/jcr_root/apps/core/wcm/components/image/v3/image/clientlibs/editor/js/image.js
Outdated
Show resolved
Hide resolved
Incorporate review comments.
@mohiaror , could you please add UI test for this fix? |
@mohiaror Changes that I applied was regarding page properties image section |
Incorporate changes done in other PR - b5e6a56
|
|
Make changes work for multiple fileupload instances present in a custom multifield component.
Fixes #1, Fixes #2