Handle all incoming and outgoing ETags according to RFC2616 / RFC7232 #828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afranken
force-pushed
the
807-if-match-etag-fixes-ctd
branch
from
6391f48 to
cf714e4
Compare
afranken
changed the title
afranken
force-pushed
the
807-if-match-etag-fixes-ctd
branch
4 times, most recently
from
d25ec60 to
dd4ab74
Compare
Fixes ETag handling in GetObject, HeadObject, CopyObject, UploadPartCopy APIs. We are now generating and storing ETags in the "RFC-Format" with enclosing double quotes. Incoming ETags are used verbatim to compare against the internally held representation. Wildcard ETags are also correctly handled. Fixes #807
Verified all tests against S3. NoneMatch on get/head object returns NOT_MODIFIED. NoneMatch on copy returns PRECONDITION_FAILED. PRECONDITION_FAILED error message was wrong. Copy tests specified a wrong range. Fixes #807
afranken
force-pushed
the
807-if-match-etag-fixes-ctd
branch
from
f84818d to
4d947bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Fixes #807
Tasks