UE: Fixing Buttons in Wizard not visible nor editable in content tree #259
Conversation
| } | ||
|
|
||
| const submitBtn = panel.querySelector('.submit-wrapper'); | ||
| if (submitBtn) { | ||
| wrapper.append(submitBtn); | ||
| panel.append(submitBtn); | ||
| } |
There was a problem hiding this comment.
You shouldn't modify the runtime to fix authoring issues.
This change has broken the way submit and reset buttons appear in wizard
https://ue-wizard-buttons--aem-boilerplate-forms--adobe-rnd.aem.page/content/aem-boilerplate-forms-xwalk-collaterals/wizard
There was a problem hiding this comment.
@ravise5 The change in appearance is intentional and it has not broken anything in terms of functionality.
Submit and reset buttons were put into the wrapper that contained next and previous buttons which was excluded from annotation, and so there was no way to delete these components as they were not being rendered in the content tree.
Ideally this should have been appended to the bottom of the wizard as it is being done now. This way, whenever authors add reset/submit buttons in any of the panels of the wizard, they get pulled out and put in the bottom of the wizard, but still inside the runtime scope of the wizard to allow for functioning and deletion to take place.
There was a problem hiding this comment.
Need to discuss if we want to break the existing styling for fixing an authoring issue :)
There was a problem hiding this comment.
Submit and reset button should be backed by some jcr resource if we want them to be editable or visible in tree. Can someone explain the exact requirement here?
There was a problem hiding this comment.
Context:
@nit23uec
Currently the code in wizard is written such that if a reset or submit button is added it places them in a wrapper.
This wrapper has some css that aligns them in same level. Due to this wrapper annotation is not working for reset or submit added inside a wizard.
There was a problem hiding this comment.
@jalagari Need your inputs in this
TalmizAhmed
changed the title
TalmizAhmed
changed the title
Reset and submit buttons in wizard will now be editable through canvas but will still be appended to the bottom of the wizard if inserted inside any internal panel.
Jira: https://jira.corp.adobe.com/browse/FORMS-15648
Authoring test: https://author-p133911-e1313554.adobeaemcloud.com/ui#/@formsinternal01/aem/universal-editor/canvas/author-p133911-e1313554.adobeaemcloud.com/content/forms/af/bugsfinding.html?ref=ue-wizard-buttons
Test URLs: