Skip to content
This repository was archived by the owner on Apr 4, 2025. It is now read-only.

Conversation

TalmizAhmed
Copy link

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:

Copy link

aem-code-sync bot commented Sep 18, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Sep 18, 2024

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@TalmizAhmed TalmizAhmed changed the title Telephone as a OOTB decorated component with type tel feat: Telephone as a OOTB decorated component with type tel Sep 18, 2024
Copy link

@nit23uec nit23uec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, pls implement it as OOTB component

@nit23uec
Copy link

this won't work until the cc is released

@TalmizAhmed TalmizAhmed requested a review from vdua March 11, 2025 12:45
@ravise5
Copy link

ravise5 commented Mar 13, 2025

@TalmizAhmed update test url and fix the test cases.

Copy link

@ravise5 ravise5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

ravise5
ravise5 previously approved these changes Mar 18, 2025
@ravise5
Copy link

ravise5 commented Mar 18, 2025

@TalmizAhmed have you checked if latest core-components support tel fieldtype now?

@TalmizAhmed
Copy link
Author

@ravise5 Yes the changes are a part of core-forms-components-reactor-1.1.54.
CC PR: adobe/aem-core-forms-components#1409

@TalmizAhmed
Copy link
Author

ravise5
ravise5 previously approved these changes Mar 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants