Skip to content

Conversation

@wkpark
Copy link

@wkpark wkpark commented Jun 8, 2023

some extensions save_image() before/after image processing without proper pnginfo["parameters"] setted.
this fix checks some cases.

@adieyal
Copy link
Owner

adieyal commented Jul 8, 2023

Is this different to simply catching a AttributeErrors and KeyErrors?

@wkpark
Copy link
Author

wkpark commented Jul 8, 2023

Is this different to simply catching a AttributeErrors and KeyErrors?

It is simply a matter of taste I guess. my suggestion is simply ignore any images without parameters info. (BTW this issue encouraged me to fix that extension issue.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants