Skip to content

Conversation

@inbarbarkai
Copy link

Hi,

I've implemented a possible solution for the BasicPublishBatch.

@odalet odalet changed the base branch from master to dev November 9, 2020 16:07
@odalet odalet merged commit edfc012 into addupsolutions:dev Nov 9, 2020
@odalet
Copy link

odalet commented Nov 9, 2020

Thanks for your contribution, I'll probably tweak it a bit (style), then merge it back into master.

@odalet odalet added this to the v1.3.0 milestone Nov 9, 2020
@inbarbarkai
Copy link
Author

@odalet You should add .editorconfig file and maybe style cop to define the code styles you want.
It would make PR's a little more easy.

@odalet
Copy link

odalet commented Nov 10, 2020

Yeah, I know, but I didn't bother setting this up, and my own style preferences are somewhat personal and sometimes based on feeling rather than precise rules, hence probably difficult to hard code in a set of rules...
I also tend to understand other people's code by rewriting it. This rewriting is by no way a judgement by the way. So, and at least until I'm overwhelmed with PRs, I don't think I'll enforce anything for now.

Anyway, your contributions where very welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants