Skip to content

Fix: Missing sourceinfo causes property lookup on undefined object #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joe-allen-89 merged 2 commits into from
Jun 11, 2024
Merged

Fix: Missing sourceinfo causes property lookup on undefined object #204

joe-allen-89 merged 2 commits into from
Jun 11, 2024

Conversation

@oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented May 15, 2024

fixes #180

Fix

  • Added guard to property lookup
  • Prevent asking user to pick update pathways where there are none

@oliverfoster oliverfoster self-assigned this May 15, 2024
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@cahirodoherty-learningpool cahirodoherty-learningpool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

swashbuck
swashbuck approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

joe-allen-89
joe-allen-89 approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 working as expected.

@joe-allen-89 joe-allen-89 merged commit 7d21def into master Jun 11, 2024
@joe-allen-89 joe-allen-89 deleted the issue/180b branch June 11, 2024 14:08
github-actions bot pushed a commit that referenced this pull request Jun 11, 2024
@semantic-release-bot
Chore(release): 3.1.5 [skip ci]
f8cc1b7 
## [3.1.5](v3.1.4...v3.1.5) (2024-06-11)

### Fix

* Missing sourceinfo causes property lookup on undefined object (fixes #204) ([7d21def](7d21def)), closes [#204](#204)
@github-actions
Copy link

github-actions bot commented Jun 11, 2024

🎉 This PR is included in version 3.1.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chris-steele chris-steele mentioned this pull request Sep 20, 2024
Closed
@chris-steele chris-steele mentioned this pull request Jun 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swashbuck swashbuck swashbuck approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

Assignees

@oliverfoster oliverfoster

Labels

bug released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

update fails if a plugin is not bower registered

5 participants

@oliverfoster @swashbuck @cahirodoherty-learningpool @joe-allen-89