Remove restoreKeys to clear cache after update
#285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
schuenadel
changed the title
restoreKeys to clear cache after update
Contributor
|
Hello @schuenadel. Could you please sync with the main branch ? |
Contributor
Author
|
@dmitry-shibanov done ✅ |
…-after-dependency-update
marko-zivic-93
approved these changes
Jul 14, 2022
|
This is a bad change, this effectively makes caching useless when the linked file like |
|
Yes, setup-java should use a per build system strategy for setting the restore-keys, for maven build system this change is really bad |
tdfacer
pushed a commit
to ifit/setup-java
that referenced
this pull request
Oct 7, 2025
…ter-dependency-update Remove `restoreKeys` to clear cache after update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Suggestion (like commented here) to remove fallback hash key to avoid keeping dependencies "forever". Start with a completely clean cache whenever any dependency changes.
Related issue:
#269
Check list: