Add new logs path related to runner migration #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
Adds flexible log directory resolution for migrated runner paths and improves error handling in the Get-UseNodeLogs test helper.
- Introduces a list of candidate paths (
actions-runner/cached/_diag/pagesandrunners/*/_diag/pages) and selects the first existing one. - Resolves the selected path before searching for
setup-node@vlog entries. - Adds error messages when no valid path or matching log file is found.
Comments suppressed due to low confidence (1)
tests/Node.Tests.ps1:12
- [nitpick] The variable name
$possiblePathsis generic; consider renaming it to something like$candidateLogPathsto clarify its purpose.
$possiblePaths = @(
Co-authored-by: Copilot <[email protected]>
aparnajyothi-y
approved these changes
Jul 11, 2025
priya-kinthali
approved these changes
Jul 11, 2025
gowridurgad
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to validate logs path based on runners