Skip to content

Change release trigger #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2022
Merged

Change release trigger #2

merged 1 commit into from
Jul 13, 2022

Conversation

yoannchaudet
Copy link
Contributor

nit: Shouldn't we use the published event instead of the edited one? We could legitimately want to edit a past release and not want to run the release workflow again.

I think this event is properly triggered when publishing a draft.

cc @YiMysty

@yoannchaudet yoannchaudet requested a review from a team as a code owner July 13, 2022 21:00
YiMysty
YiMysty approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@YiMysty YiMysty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be good to modify :)

@yoannchaudet yoannchaudet merged commit bfe36bc into main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@YiMysty YiMysty YiMysty approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoannchaudet @YiMysty