Improve a few contribution notes in the README #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoannchaudet
reviewed
Aug 5, 2022
README.md
Outdated
|
|
||
| 2. Push a matching tag, for instance for `v0.1.0`: | ||
| 2. Push a matching tag (e.g.`v0.1.0`) **if** different than the `main` branch (if not, publishing the draft release will create it): |
There was a problem hiding this comment.
Really? That's cool, do we even need this whole step then?
There was a problem hiding this comment.
No, not really. I didn't do it at all for the latest release.
There was a problem hiding this comment.
We can consider removing it in the future, but there is probably a bit more clarification to add regarding making sure the branch name is correct in the Release UI and such. 🤔
There was a problem hiding this comment.
I published without yesterday. Let's remove the step. Publishing a release does it for us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve a few contribution notes in the README related to release management 🤷🏻♂️