Skip to content

wrap pipeline commands for submoduleForeach in quotes #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 16, 2022
Merged

wrap pipeline commands for submoduleForeach in quotes #964

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fb318fb
wrap pipeline commands for submoduleForeach in quotes
jokreliable Oct 14, 2022
1216f2d
Update src/git-auth-helper.ts
jokreliable Nov 10, 2022
b9bc990
Followed CONTRIBUTING.md instructions, updating dist/index.js
jokreliable Nov 11, 2022
3f114b8
fixed package-lock.json
jokreliable Nov 15, 2022
0318988
updating the pipeline so it runs from sh
jokreliable Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/git-auth-helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,8 @@ class GitAuthHelper {
// by process creation audit events, which are commonly logged. For more information,
// refer to https://docs.microsoft.com/en-us/windows-server/identity/ad-ds/manage/component-updates/command-line-process-auditing
const output = await this.git.submoduleForeach(
`git config --local '${this.tokenConfigKey}' '${this.tokenPlaceholderConfigValue}' && git config --local --show-origin --name-only --get-regexp remote.origin.url`,
// wrap the pipeline in quotes to make sure it's handled properly by submoduleForeach, rather than just the first part of the pipeline
`"git config --local '${this.tokenConfigKey}' '${this.tokenPlaceholderConfigValue}' && git config --local --show-origin --name-only --get-regexp remote.origin.url"`,
this.settings.nestedSubmodules
)

Expand Down Expand Up @@ -365,7 +366,8 @@ class GitAuthHelper {

const pattern = regexpHelper.escape(configKey)
await this.git.submoduleForeach(
`git config --local --name-only --get-regexp '${pattern}' && git config --local --unset-all '${configKey}' || :`,
// wrap the pipeline in quotes to make sure it's handled properly by submoduleForeach, rather than just the first part of the pipeline
`"git config --local --name-only --get-regexp '${pattern}' && git config --local --unset-all '${configKey}' || : "`,
true
)
}
Expand Down