Refactor ABSmartly configuration setup to allow for all the configuration to be specified through the ABSmartlyConfig object #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvCW
force-pushed
the
config_refactor
branch
7 times, most recently
from
a0fb82c to
b8759bf
Compare
dhruvCW
force-pushed
the
config_refactor
branch
from
a5317f7 to
ba89c02
Compare
dhruvCW
changed the title
|
Hey @dhruvCW , can you change the file lib/absmartly/version.rb with the version number 1.2 please? |
|
@dhruvCW , see if is possible to add this PR https://github.com/absmartly/ruby-sdk/pull/28/files together with this version, please? |
Done cherry picked the changes onto this branch and updated the version file as well 👍 |
hermeswaldemarin
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ABSmartlyConfigobject. The instance now contains a copy of theClientConfigand intern theDefaultHttpConfigwhich allows for all the configuration to be setup via theABsmartly.configure_clientmethod.ABsmartlythread safe.context_event_loggercan now be directly configured with a proc or lambda which will automatically wrap it inContextEventLoggerCallbackinstance.Note
All changes should ideally be backwards compatible but have only been verified using the existing test suite.
Test
ABSmartly.createto use another one.