Skip to content

Conversation

Musilah
Copy link
Contributor

@Musilah Musilah commented Sep 10, 2025

What type of PR is this?

This is a bug fix as it fixes users groups and channels

What does this do?

It fixes users channels and groups

Which issue(s) does this PR fix/relate to?

N/A

Have you included tests for your changes?

No

Did you document any new/modified feature?

No

Notes

@Musilah Musilah marked this pull request as ready for review September 10, 2025 11:52
@Musilah Musilah requested a review from a team as a code owner September 10, 2025 11:52
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

❌ Patch coverage is 92.07921% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.62%. Comparing base (1f48a73) to head (7393c95).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
groups/postgres/groups.go 92.30% 4 Missing ⚠️
users/postgres/users.go 91.30% 2 Missing ⚠️
channels/postgres/channels.go 88.88% 1 Missing ⚠️
domains/postgres/domains.go 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3138      +/-   ##
==========================================
+ Coverage   34.81%   41.62%   +6.81%     
==========================================
  Files         330       94     -236     
  Lines       48915    22009   -26906     
==========================================
- Hits        17030     9162    -7868     
+ Misses      31028    12349   -18679     
+ Partials      857      498     -359     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dborovcanin
Copy link
Collaborator

@Musilah Please rebase and fix CI.

Signed-off-by: musilah <[email protected]>
Signed-off-by: musilah <[email protected]>
Signed-off-by: musilah <[email protected]>
Signed-off-by: musilah <[email protected]>
Signed-off-by: musilah <[email protected]>
Signed-off-by: musilah <[email protected]>
@dborovcanin dborovcanin merged commit 29f7063 into absmach:main Sep 18, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants