Skip to content

Conversation

felixgateru
Copy link
Contributor

@felixgateru felixgateru commented Jun 10, 2025

What type of PR is this?

This is a feature because it adds websocket support to the http adapter.

What does this do?

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Yes, tests have been updated

Did you document any new/modified feature?

Yes, in code documentation has been updated

Notes

To be merged after: absmach/mgate#99

@felixgateru felixgateru marked this pull request as ready for review June 13, 2025 14:59
@felixgateru felixgateru requested a review from a team as a code owner June 13, 2025 14:59
@felixgateru felixgateru force-pushed the smq2800-ws branch 3 times, most recently from 75c6387 to 45456ac Compare June 17, 2025 15:44
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

Attention: Patch coverage is 40.59701% with 199 lines in your changes missing coverage. Please review.

Project coverage is 25.79%. Comparing base (898048c) to head (e739d56).

Files with missing lines Patch % Lines
http/mocks/service.go 0.00% 118 Missing ⚠️
http/api/endpoint.go 50.00% 23 Missing and 8 partials ⚠️
http/handler.go 76.40% 16 Missing and 5 partials ⚠️
http/api/transport.go 62.26% 17 Missing and 3 partials ⚠️
http/adapter.go 57.14% 2 Missing and 1 partial ⚠️
http/middleware/logging.go 0.00% 2 Missing ⚠️
http/middleware/metrics.go 0.00% 2 Missing ⚠️
http/middleware/tracing.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2937      +/-   ##
==========================================
+ Coverage   23.88%   25.79%   +1.91%     
==========================================
  Files         359      306      -53     
  Lines       67963    61917    -6046     
==========================================
- Hits        16231    15971     -260     
+ Misses      50939    45155    -5784     
+ Partials      793      791       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dborovcanin
Copy link
Collaborator

@felixgateru Please rebase this one.

Signed-off-by: Felix Gateru <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add WebSocket support to HTTP Adapter
2 participants