Skip to content

Conversation

felixgateru
Copy link
Contributor

@felixgateru felixgateru commented May 7, 2024

What type of PR is this?

This is a feature because it updates the coap adapter to use mgate to procy plain udp traffic and dtls traffic.

What does this do?

This pr updates the coap adapter to use mgate for proxtying

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

No

Did you document any new/modified feature?

No

Notes

@dborovcanin
Copy link
Collaborator

@felixgateru Please resolve conflicts.

Copy link

codecov bot commented Sep 8, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@felixgateru felixgateru self-assigned this Sep 9, 2025
@felixgateru felixgateru moved this to 🚧 In Progress in SuperMQ Sep 9, 2025
@felixgateru felixgateru changed the title MG-1963 - Proxy CoAP using mproxy MG-1963 - Proxy CoAP using mgate Sep 9, 2025
@felixgateru felixgateru removed this from SuperMQ Sep 9, 2025
@felixgateru felixgateru changed the title MG-1963 - Proxy CoAP using mgate MG-3137 - Proxy CoAP using mgate Sep 9, 2025
@felixgateru felixgateru changed the title MG-3137 - Proxy CoAP using mgate SMQ-3137 - Proxy CoAP using mgate Sep 9, 2025
@felixgateru felixgateru force-pushed the MG1963-proxy_coap branch 3 times, most recently from e84d707 to c9dcaaa Compare September 18, 2025 13:36
@felixgateru felixgateru marked this pull request as ready for review September 18, 2025 13:49
@felixgateru felixgateru requested a review from a team as a code owner September 18, 2025 13:49
@absmach absmach deleted a comment from davidosodo Sep 23, 2025
@absmach absmach deleted a comment from davidosodo Sep 23, 2025
docker/.env Outdated
SMQ_COAP_ADAPTER_PORT=5683
SMQ_COAP_ADAPTER_SERVER_CERT=
SMQ_COAP_ADAPTER_SERVER_KEY=
SMQ_COAP_ADAPTER_SERVER_CA_FILE=
Copy link
Contributor

@rodneyosodo rodneyosodo Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • DTLS certs are not mapped inside the container
  • DTLS certs are not correctly inputed
SMQ_COAP_ADAPTER_SERVER_CERT_FILE=""
  • On docker/ssl/Makefile, lets add this so that we can generate CoAP server certs
COAP_GRPC_SERVER_CONF_FILE_NAME=coap-server.conf
COAP_GRPC_SERVER_CN=coap
COAP_GRPC_SERVER_CRT_FILE_NAME=coap-server

coap_grpc_certs:
	$(call gen_grpc_cert,$(COAP_GRPC_SERVER_CRT_FILE_NAME),$(COAP_GRPC_SERVER_CN))

  • We should consider an env variable that enables COAP_DTLS same as GRPC_MTLS

Copy link
Contributor

@rodneyosodo rodneyosodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also consider updating the docs repo for this new feature

Copy link
Contributor

@rodneyosodo rodneyosodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Support for CoAP with DTLS
3 participants