-
Notifications
You must be signed in to change notification settings - Fork 674
SMQ-3137 - Proxy CoAP using mgate #2222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@felixgateru Please resolve conflicts. |
01c3593
to
bedc5b3
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
bedc5b3
to
d7da4fa
Compare
e84d707
to
c9dcaaa
Compare
docker/.env
Outdated
SMQ_COAP_ADAPTER_PORT=5683 | ||
SMQ_COAP_ADAPTER_SERVER_CERT= | ||
SMQ_COAP_ADAPTER_SERVER_KEY= | ||
SMQ_COAP_ADAPTER_SERVER_CA_FILE= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- DTLS certs are not mapped inside the container
- DTLS certs are not correctly inputed
SMQ_COAP_ADAPTER_SERVER_CERT_FILE=""
- On
docker/ssl/Makefile
, lets add this so that we can generate CoAP server certs
COAP_GRPC_SERVER_CONF_FILE_NAME=coap-server.conf
COAP_GRPC_SERVER_CN=coap
COAP_GRPC_SERVER_CRT_FILE_NAME=coap-server
coap_grpc_certs:
$(call gen_grpc_cert,$(COAP_GRPC_SERVER_CRT_FILE_NAME),$(COAP_GRPC_SERVER_CN))
- We should consider an env variable that enables
COAP_DTLS
same asGRPC_MTLS
c9dcaaa
to
1783a8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also consider updating the docs repo for this new feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
26f3e6b
to
737dc19
Compare
What type of PR is this?
This is a feature because it updates the coap adapter to use mgate to procy plain udp traffic and dtls traffic.
What does this do?
This pr updates the coap adapter to use mgate for proxtying
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
No
Did you document any new/modified feature?
No
Notes