Skip to content

Fix CompressedTuple move constructor on MSVC #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2020
Merged

Fix CompressedTuple move constructor on MSVC #637

merged 2 commits into from
Mar 12, 2020

Conversation

i-do-cpp
Copy link
Contributor

@i-do-cpp i-do-cpp commented Mar 11, 2020 •
edited
Loading

Fixes #357

Please review, I'm unsure if the enable_if guard has the same effect as the old one.

@pizzard
Copy link
Contributor

pizzard commented Mar 11, 2020 •
edited
Loading

To provide some more context:
This should allow using abseil with the latest MSVC in the /permissive- mode.
The fix is derived from the MSVC STL, which does this similarly.

@derekmauro derekmauro self-assigned this Mar 11, 2020
derekmauro
derekmauro approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@derekmauro derekmauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! This passed all our tests. I pushed some style fixes to your branch. This will be merged soon.

@derekmauro derekmauro merged commit b92f35f into abseil:master Mar 12, 2020
absl-federation-github pushed a commit that referenced this pull request Mar 12, 2020
@derekmauro
Export of internal Abseil changes
c695489 
--
66a0a46462692378f77518f9db766a218bfac40b by Derek Mauro <[email protected]>:

Internal change

PiperOrigin-RevId: 300565981

--
2a1ad67662b2e22beec7d3be019e6bba23c41c7f by Derek Mauro <[email protected]>:

Fix CompressedTuple move constructor on MSVC
Imports GitHub #637

PiperOrigin-RevId: 300545840

--
a3ee3ad036bbb6b0031121fd58299e5c59a243e1 by Derek Mauro <[email protected]>:

Disable LLVM's XRay instrumentation on Android
Fixes #626

PiperOrigin-RevId: 300540906

--
87999244b1f825e585ec12a431086cb60daeb24f by Gennadiy Rozental <[email protected]>:

Increase max cord depth by 2.
After reviewing of the paper we can prove that the algorithm in fact can lead to slightly larger max depth.

PiperOrigin-RevId: 300422376

--
98de175ee8ad33290ef883c167c2de4414a11007 by Abseil Team <[email protected]>:

Use *opt/opt-> instead of opt.value() in an example, after checking the optional has a value.

PiperOrigin-RevId: 300253502

--
1107aa0acf0fe743ef50173e02e48f0d4eb572ef by Derek Mauro <[email protected]>:

Stop overriding the default system C++ dialect in CMake

CMake on MacOS has some very strange defaults, like Wno-c++11-extensions,
and doesn't seem to respect CMAKE_CXX_STANDARD, so use CMAKE_CXX_FLAGS instead.

PiperOrigin-RevId: 300180753
GitOrigin-RevId: 66a0a46462692378f77518f9db766a218bfac40b
Change-Id: Icd7b84c49306441b012cb87f244cc92a11697db8
@LilyWangL LilyWangL mentioned this pull request Apr 7, 2020
Merged
absl-federation-github pushed a commit that referenced this pull request Sep 23, 2020
@rogeeff
Creation of LTS branch "lts_2020_09_23"
cb9b33f 
  - d3614de Export of internal Abseil changes by Abseil Team <[email protected]>
  - 20feb1c Export of internal Abseil changes by Abseil Team <[email protected]>
  - c1ae0a4 Export of internal Abseil changes by Abseil Team <[email protected]>
  - 6af91b3 Export of internal Abseil changes by Abseil Team <[email protected]>
  - f2c9c66 Export of internal Abseil changes by Abseil Team <[email protected]>
  - 3c8b5d7 Export of internal Abseil changes by Abseil Team <[email protected]>
  - 7ba8cdb Export of internal Abseil changes by Abseil Team <[email protected]>
  - 930fbec Export of internal Abseil changes by Abseil Team <[email protected]>
  - 0e9921b Export of internal Abseil changes by Abseil Team <[email protected]>
  - a4cbb5f Export of internal Abseil changes by Abseil Team <[email protected]>
  - 4d2ff38 Export of internal Abseil changes by Abseil Team <[email protected]>
  - c03c18e Export of internal Abseil changes by Abseil Team <[email protected]>
  - b321ad8 Export of internal Abseil changes by Abseil Team <[email protected]>
  - fbf0fda Export of internal Abseil changes by Abseil Team <[email protected]>
  - dc969f3 Export of internal Abseil changes by Abseil Team <[email protected]>
  - d0c4334 Export of internal Abseil changes by Abseil Team <[email protected]>
  - c6b3f2c Export of internal Abseil changes by Abseil Team <[email protected]>
  - 1beb319 Export of internal Abseil changes by Abseil Team <[email protected]>
  - 1b7e751 Export of internal Abseil changes by Abseil Team <[email protected]>
  - ce4bc92 Export of internal Abseil changes by Abseil Team <[email protected]>
  - f72cc35 Export of internal Abseil changes by Abseil Team <[email protected]>
  - f66bc74 Export of internal Abseil changes by Abseil Team <[email protected]>
  - 1995c6a Export of internal Abseil changes by Abseil Team <[email protected]>
  - 184cf25 Export of internal Abseil changes by Abseil Team <[email protected]>
  - 82302f1 Export of internal Abseil changes by Abseil Team <[email protected]>
  - dea7648 Export of internal Abseil changes by Abseil Team <[email protected]>
  - d39fe6c Export of internal Abseil changes by Abseil Team <[email protected]>
  - 2c8a5b0 Export of internal Abseil changes by Abseil Team <[email protected]>
  - 41a6263 Export of internal Abseil changes by Abseil Team <[email protected]>
  - 3c2bed2 Export of internal Abseil changes by Abseil Team <[email protected]>
  - ea8a689 fix build on P9 (#739) by jglaser <[email protected]>
  - 672d9e0 Export of internal Abseil changes by Abseil Team <[email protected]>
  - f624790 Export of internal Abseil changes by Abseil Team <[email protected]>
  - 55c04eb Export of internal Abseil changes by Abseil Team <[email protected]>
  - 302b250 Disable pthread for standalone wasm build support (#721) by Rei Shimizu <[email protected]>
  - 61d8bc0 Merge branch 'master' of https://github.com/abseil/abseil... by Gennadiy Rozental <[email protected]>
  - d5269a8 Export of internal Abseil changes by Abseil Team <[email protected]>
  - bf655de Export of internal Abseil changes by Abseil Team <[email protected]>
  - 38db52a Export of internal Abseil changes by Abseil Team <[email protected]>
  - 81f34df Export of internal Abseil changes by Abseil Team <[email protected]>
  - b86fff1 Export of internal Abseil changes by Abseil Team <[email protected]>
  - 10cb35e Export of internal Abseil changes by Abseil Team <[email protected]>
  - 4ccc0fc Export of internal Abseil changes by Abseil Team <[email protected]>
  - 4a85104 Export of internal Abseil changes by Abseil Team <[email protected]>
  - ccdbb59 Export of internal Abseil changes by Abseil Team <[email protected]>
  - 01f5f81 Export of internal Abseil changes by Abseil Team <[email protected]>
  - 2c92bdc Export of internal Abseil changes by Abseil Team <[email protected]>
  - e7ebf98 Export of internal Abseil changes by Abseil Team <[email protected]>
  - 2eba343 Export of internal Abseil changes by Abseil Team <[email protected]>
  - a8b03d9 Export of internal Abseil changes by Abseil Team <[email protected]>
  - 1d31b5c Export of internal Abseil changes by Abseil Team <[email protected]>
  - da3a876 Export of internal Abseil changes by Abseil Team <[email protected]>
  - 8faf204 Exclude empty directories (#697) by Po-Chuan Hsieh <[email protected]>
  - 2069dc7 Export of internal Abseil changes by Abseil Team <[email protected]>
  - 4832bf6 Added a BUILD file in root to expose license. (#695) by Dylan Madisetti <[email protected]>
  - af8f994 Export of internal Abseil changes by Abseil Team <[email protected]>
  - 33caf10 Export of internal Abseil changes by Abseil Team <[email protected]>
  - cf1a02e Export of internal Abseil changes by Abseil Team <[email protected]>
  - 768eb2c Export of internal Abseil changes by Abseil Team <[email protected]>
  - 3f347c4 Fix build on riscv32 (#675) by Khem Raj <[email protected]>
  - 62cf6a7 Export of internal Abseil changes by Abseil Team <[email protected]>
  - d118d4b Export of internal Abseil changes by Abseil Team <[email protected]>
  - f2bc9d1 Fix public target name of the random library (#684) by Nicholas Bishop <[email protected]>
  - 0fecf0e Export of internal Abseil changes by Abseil Team <[email protected]>
  - cbfd0f0 Export of internal Abseil changes by Abseil Team <[email protected]>
  - c45d1c0 Export of internal Abseil changes by Abseil Team <[email protected]>
  - a35ef8a Export of internal Abseil changes by Abseil Team <[email protected]>
  - bd317ca Export of internal Abseil changes by Abseil Team <[email protected]>
  - b115744 fix MSVC warning 4245: conversion signed => unsigned duri... by Christoph Cullmann <[email protected]>
  - d85783f Export of internal Abseil changes by Abseil Team <[email protected]>
  - a1d6689 Export of internal Abseil changes by Abseil Team <[email protected]>
  - ca9856c Export of internal Abseil changes by Abseil Team <[email protected]>
  - 6e18c71 Export of internal Abseil changes by Abseil Team <[email protected]>
  - 3f48ce1 init (#673) by Fu Zhe <[email protected]>
  - cde2e24 Export of internal Abseil changes by Abseil Team <[email protected]>
  - 68494aa Fix CMake Threads dependency issue by Zach Toogood <[email protected]>
  - 902909a Export of internal Abseil changes by Abseil Team <[email protected]>
  - cb52b05 Export of internal Abseil changes by Abseil Team <[email protected]>
  - 1a02b7a Use "-lrt" instead of the resolved find_library result wh... by László Nagy <[email protected]>
  - df60c82 Export of internal Abseil changes by Abseil Team <[email protected]>
  - b35973e Export of internal Abseil changes by Abseil Team <[email protected]>
  - db5773a Export of internal Abseil changes by Abseil Team <[email protected]>
  - 71079e4 Export of internal Abseil changes by Abseil Team <[email protected]>
  - 2946ac0 Use base_internal::AtomicHook instead of std::atomic (#661) by Pavel Samolysov <[email protected]>
  - 567bee2 Fix ABSL_RANDOM_RANDEN_COPTS setting on FreeBSD (#664) by Po-Chuan Hsieh <[email protected]>
  - bf6166a Export of internal Abseil changes by Abseil Team <[email protected]>
  - 1112609 Export of internal Abseil changes by Abseil Team <[email protected]>
  - 73ea9a9 Export of internal Abseil changes by Abseil Team <[email protected]>
  - c01b991  Add option to use an externally provided GoogleTest targ... by Adrian Imboden <[email protected]>
  - d43b799 Export of internal Abseil changes by Abseil Team <[email protected]>
  - 62f05b1 Export of internal Abseil changes by Abseil Team <[email protected]>
  - fba8a31 Export of internal Abseil changes by Abseil Team <[email protected]>
  - 79e0dc1 Export of internal Abseil changes by Abseil Team <[email protected]>
  - 132d791 bazel: Add missing load statements for cc_binary (#645) by Yannic <[email protected]>
  - 518f175 Export of internal Abseil changes by Abseil Team <[email protected]>
  - 092ed97 Export of internal Abseil changes by Abseil Team <[email protected]>
  - 2d2a8ae Export of internal Abseil changes by Abseil Team <[email protected]>
  - 7853a75 Export of internal Abseil changes by Abseil Team <[email protected]>
  - c695489 Export of internal Abseil changes by Abseil Team <[email protected]>
  - b92f35f Fix CompressedTuple move constructor on MSVC (#637) by i-do-cpp <[email protected]>
  (And 9 more changes)

GitOrigin-RevId: d3614de
Change-Id: I589267fa36251e17cd1e95061b702edcafd1a3ad
rongjiecomputer pushed a commit to rongjiecomputer/abseil-cpp that referenced this pull request Oct 8, 2020
@i-do-cpp @rongjiecomputer
Fix CompressedTuple move constructor on MSVC (abseil#637)
d758c1d
rongjiecomputer pushed a commit to rongjiecomputer/abseil-cpp that referenced this pull request Oct 8, 2020
@rongjiecomputer
Export of internal Abseil changes
de3b43a 
--
66a0a46462692378f77518f9db766a218bfac40b by Derek Mauro <[email protected]>:

Internal change

PiperOrigin-RevId: 300565981

--
2a1ad67662b2e22beec7d3be019e6bba23c41c7f by Derek Mauro <[email protected]>:

Fix CompressedTuple move constructor on MSVC
Imports GitHub abseil#637

PiperOrigin-RevId: 300545840

--
a3ee3ad036bbb6b0031121fd58299e5c59a243e1 by Derek Mauro <[email protected]>:

Disable LLVM's XRay instrumentation on Android
Fixes abseil#626

PiperOrigin-RevId: 300540906

--
87999244b1f825e585ec12a431086cb60daeb24f by Gennadiy Rozental <[email protected]>:

Increase max cord depth by 2.
After reviewing of the paper we can prove that the algorithm in fact can lead to slightly larger max depth.

PiperOrigin-RevId: 300422376

--
98de175ee8ad33290ef883c167c2de4414a11007 by Abseil Team <[email protected]>:

Use *opt/opt-> instead of opt.value() in an example, after checking the optional has a value.

PiperOrigin-RevId: 300253502

--
1107aa0acf0fe743ef50173e02e48f0d4eb572ef by Derek Mauro <[email protected]>:

Stop overriding the default system C++ dialect in CMake

CMake on MacOS has some very strange defaults, like Wno-c++11-extensions,
and doesn't seem to respect CMAKE_CXX_STANDARD, so use CMAKE_CXX_FLAGS instead.

PiperOrigin-RevId: 300180753
GitOrigin-RevId: 66a0a46462692378f77518f9db766a218bfac40b
Change-Id: Icd7b84c49306441b012cb87f244cc92a11697db8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekmauro derekmauro derekmauro approved these changes

Assignees

@derekmauro derekmauro

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MSVC 16.2, C++17, and /permissive- fails to build
5 participants
@i-do-cpp @pizzard @derekmauro @googlebot @kokoro-team