Gracefully handle Date.parse receiving a number #261
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm using a Vis.js Timeline component, which [internally calls `Date.parse` with a number](https://github.com/almende/vis/blob/master/lib/util.js#L395) when doing some type coersion. Calling the native parse function with a number should either return another number, or `NaN`. However, because datejs's parser doesn't check for a number input, it falls through to attempting to normalise it as a string, which fails when hitting `parseUtils.removeOrds`. Naturally, removing datejs and thus reverting to the native `Date.parse` method fixes this issue. I am happy to raise a PR with a fix, but I'm unsure whether handling numbers is something you want this method to do.
|
This would break a crap-ton of formats like 20120630 and things like that. Vis.js is the one that is incorrect here anyhow - Date.parse() is, per spec, a string parsing function. They're using it wrong. Open a PR with them - this is a won't fix. It breaks things, isn't a bug with this library, and is to work around people abusing non-spec behavior. |
|
Thanks, I appreciate the quick response! I was pretty sure this would be the case, but I figured it was worth double-checking. I'll raise a fix with Vis.js and link back here for posterity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using a Vis.js Timeline component, which internally calls
Date.parsewith a number when doing some type coersion.Calling the native parse function with a number should either return another number, or
NaN(although this isn't covered by the spec, IE/FF/Chrome all behave as such). However, because datejs's parser doesn't check for a number input, it falls through to attempting to normalise it as a string, which fails when hittingparseUtils.removeOrds.Naturally, removing datejs and thus reverting to the native
Date.parsemethod fixes this issue, but this is not an option for me as datejs's functionality is used throughout my application.Please review this pull request, as I'm unsure whether handling numbers is something you want this method to do.