alpine url bug fix and AGPL License version issue

[404-geek]

No description provided.

[pombredanne]

@404-geek Thanks... can you check the test failures? Also in the future it is usually best to avoid mixing two unrelated changes in the same PR... here the license detection issue is not related to anything about alpine VCS URL handling, AFAIK ;)

[404-geek]

@404-geek Thanks... can you check the test failures? Also in the future it is usually best to avoid mixing two unrelated changes in the same PR... here the license detection issue is not related to anything about alpine VCS URL handling, AFAIK ;)

Sure @pombredanne will take care of not keeping 2 issues in same PR in the future

I have resolved all the test issues. Can you please check once

[AyanSinhaMahapatra]

Thanks++ @404-geek , we are mostly there.

[AyanSinhaMahapatra]

While the change is correct note that the rule filenames reflect the license-expression of the rule and a change in the license-expression needs to happen like this:

1. Deprecate the current rule using the is_deprecated attribute
2. Reindex the licenses with scancode-reindex-licenses (This will remove the deprecated rule from the index so you can add a new one, otherwise two rules with the same text cannot exist in the index)
3. Add a new rule for just agpl-3.0-plus and add notes about the origin, that this was previously the src/agpl-3.0-plus_or_commercial-license_4.RULE rule. Add the issue reference in the commit. (You can paste the rule content at etc/scripts/licenses/buildrules-template.txt and then run python etc/scripts/licenses/buildrules.py etc/scripts/licenses/buildrules-template.txt in an activated virtualenv, and this will create the rule automatically, with the appropriate filename)

[404-geek]

Hi @AyanSinhaMahapatra I need some help on the buildrules-template.txt for generation.

[AyanSinhaMahapatra]

@404-geek gentle ping, we need a small update here.

[pombredanne]

@404-geek ping :) I would like to merge this soon enough!

[AyanSinhaMahapatra]

See #3740 (comment), will merge the commits thorugh #4093, closing.