feat(voice): use voice gateway v8 and support new modes #1558
+208
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babiabeo
reviewed
Oct 8, 2024
james58899
suggested changes
Jun 9, 2025
|
resume still doesn't work properly, because |
james58899
approved these changes
Jun 12, 2025
There was a problem hiding this comment.
Pull Request Overview
Updates the voice connection implementation to use Voice Gateway v8 and adds support for new encryption modes (aead_aes256_gcm_rtpsize and aead_xchacha20_poly1305_rtpsize) while replacing tweetnacl with @stablelib/xchacha20poly1305.
- Replaces tweetnacl dependency with @stablelib/xchacha20poly1305 v1.0.1 for better encryption support
- Adds support for Voice Gateway v8 with improved resuming logic and session management
- Implements new AEAD encryption modes with preference-based selection
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Replaces tweetnacl with @stablelib/xchacha20poly1305 and removes browser exclusion |
| lib/voice/VoiceConnection.js | Major refactor implementing v8 gateway features, new encryption modes, and improved connection handling |
| lib/Constants.js | Adds VOICE_VERSION constant set to 8 |
|
|
||
| // RFC3550 5.1: Padding (may need testing) | ||
| if (hasPadding) { | ||
| const paddingAmount = data.subarray(0, data.length - 1); |
There was a problem hiding this comment.
Incorrect padding calculation. Should read the last byte of data to get padding amount: const paddingAmount = data[data.length - 1];
Suggested change
| const paddingAmount = data.subarray(0, data.length - 1); | |
| const paddingAmount = data[data.length - 1]; |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
@abalabahaha please confirm
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a modified version of a combination of PRs on dysnomia: projectdysnomia/dysnomia#156, projectdysnomia/dysnomia#160, projectdysnomia/dysnomia#168
@stablelib/xchacha20poly1305replaces tweetnacl, it uses v1 since v2 is in ESM.resumingis set while connecting instead of before.