Update ValidationLogic.sol #940
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The added natspec comment will help eliminate any misunderstandings/confusions around the implementation choice for the specific `require()` check in question. Additionally, the current error message is somewhat misleading, as it clearly states below `<` HF liquidation threshold constant, while the implemented logic says `<=`. So probably a good idea to change the error message to better reflect the actual implemented logic.
dappconsulting
requested review from
The-3D,
eboadom,
foodaka,
kyzia551,
miguelmtzinf and
sakulstra
as code owners
|
solophbs
reviewed
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added natspec comment will help eliminate any misunderstandings/confusions around the implementation choice for the specific
require()check in question.Additionally, the current error message is somewhat misleading, as it clearly states below
<HF liquidation threshold constant, while the implemented logic says<=. So probably a good idea to change the error message to better reflect the actual implemented logic.