Skip to content

Conversation

livingos
Copy link
Contributor

Fixes #161

Updates isError to handle missing FunctionError key as result of latest aws-sdk-php package.

@livingos livingos changed the title settleresult-iserror-fix SettledResult isError fix Jul 31, 2025
@yassir3wad
Copy link

@aarondfrancis - Are you able to merge this PR?

@andrepg
Copy link

andrepg commented Aug 1, 2025

Thanks! I've applied this fix manually in my code and can confirm that it worked as expected.

I'm using Sidecar v0.7.0 and AWS versions SDK v3.351.12 (in production) and v3.351.6 (in development). In development we have a working code, but in production we don't.

Additionaly, I'm receiving just an Lambda Execution Exception for Wnx\SidecarBrowsershot\Functions\BrowsershotFunction: "Unknown error.". as a result of the execution.

Applying the PR code no longer throws an error.

@iAmKevinMcKee
Copy link

You can lock to 3.351.9 until this is merged.

@Akecel
Copy link
Contributor

Akecel commented Aug 8, 2025

Thanks for that @livingos , I hope it will be merged quickly 💯

@patrickomeara
Copy link

To use this before it is merged set the following in your composer.json file.

{
    "require": {
        "hammerstone/sidecar": "dev-main#5836667 as 0.7.0",
    },
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/Erudus/sidecar"
        }
    ],
}

@alexbirtwell
Copy link

+1 for this fix to merge please.

@inxilpro inxilpro merged commit 7701553 into aarondfrancis:main Aug 22, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest aws-sdk-php version 3.351.10 breaks sidecar
8 participants