-
Notifications
You must be signed in to change notification settings - Fork 9
Feature: specify flaky exceptions #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: specify flaky exceptions #5
Conversation
Seems like orchestra/testbench was missing as well |
I just pushed to main before I saw this. Can you pull and update? Also can you update orchestra to allow 6, 7, or 8 |
Done. I also reverted to your implementation of determining if the exception should be thrown inside the Arbiter |
@mateusjatenee thank you for this! I modified it a bit because I didn't like something that I had done in main but hadn't released. I pulled a bit out of the Arbiter back up into the Flaky class itself. I think if protections are disabled, it should just Look ok to you? |
@aarondfrancis looks good to me bud |
Tagged in v0.1.3! |
It's been an honor to fight beside you |
This allow us to specify which exceptions should be handled by Flaky - that way we can wrap larger blocks of code inside it and only handle a few selected exceptions (if we want to).