Skip to content

Feature: specify flaky exceptions #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mateusjatenee
Copy link
Contributor

@mateusjatenee mateusjatenee commented Mar 6, 2023

This allow us to specify which exceptions should be handled by Flaky - that way we can wrap larger blocks of code inside it and only handle a few selected exceptions (if we want to).

@mateusjatenee
Copy link
Contributor Author

Seems like orchestra/testbench was missing as well

@aarondfrancis
Copy link
Owner

I just pushed to main before I saw this. Can you pull and update? Also can you update orchestra to allow 6, 7, or 8

@mateusjatenee
Copy link
Contributor Author

I just pushed to main before I saw this. Can you pull and update? Also can you update orchestra to allow 6, 7, or 8

Done. I also reverted to your implementation of determining if the exception should be thrown inside the Arbiter

@aarondfrancis
Copy link
Owner

@mateusjatenee thank you for this! I modified it a bit because I didn't like something that I had done in main but hadn't released.

I pulled a bit out of the Arbiter back up into the Flaky class itself. I think if protections are disabled, it should just throw exceptions, and not go through the throw / report / handleFailure flow at all. I think if Flaky is disabled, it's disabled. You just get exceptions as you normally would. This was what I was doing originally but I changed it around for some reason and this changes it back.

Look ok to you?

@mateusjatenee
Copy link
Contributor Author

@aarondfrancis looks good to me bud

@aarondfrancis aarondfrancis merged commit 4857196 into aarondfrancis:main Mar 6, 2023
@aarondfrancis
Copy link
Owner

Tagged in v0.1.3!

@mateusjatenee mateusjatenee deleted the feature/specific-flaky-exceptions branch March 6, 2023 21:03
@mateusjatenee
Copy link
Contributor Author

It's been an honor to fight beside you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants