InstanceID in meetingresponse.php #148
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 75a8229)
|
Hi. When your patch is applied to 2.7.6 I see the following error (I use the kopano backend): 2025/08/07 23:04:19 [error] 1665#1665: *2 FastCGI sent in stderr: "PHP message: PHP Fatal error: Declaration of BackendKopano::MeetingResponse($requestid, $folderid, $response) must be compatible with IBackend::MeetingResponse($requestid, $folderid, $response, $instanceId) in /usr/share/z-push/backend/kopano/kopano.php on line 898" while reading response header from upstream, client [snip] |
|
Yes I modified the core but not all of the backends. This patch is a breaking change and all backends must implement that new $instanceid parameter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue: Meeting response instance ID is not passed to backend #111