Fixed Find command to work with iPhone running ios 18.4.1

[mschering]

What does this implement/fix? Explain your changes.

This pull request replaces my old pull request implementing the Find command. I took the base code and tested it but ran into an issue:

The Find command implementation:

Z-Push/src/lib/request/find.php

Line 178 in af25a21

$message = self::$backend->Fetch(false, $u['longid'], $cpo);

Didn't pass the folderId to the backend Fetch() method:

Z-Push/src/lib/default/diffbackend/diffbackend.php

Line 129 in af25a21

public function Fetch($folderid, $id, $contentparameters) {

The message can't be found that way. I also pass the server ID and not the long ID as kopano is the only backend that splits the long ID:

Z-Push/src/backend/kopano/kopano.php

Line 750 in 07f60c7

list($fsk, $sk) = Utils::SplitMessageId($id);

The BackendDiff class doesn't do this.

Does this close any currently open issues?

Not sure. But it might close #141

Any relevant logs, error output, etc?

...

Where has this been tested?

Server (please complete the following information):

• OS: debian
• PHP Version: 8.3
• Backend for: Group-Office
• and Version: current development branch

Smartphone (please complete the following information):

• Device: iPhone 13
• OS: iOS 18
• Mail App Apple mail

[sebasi]

The backend should handle the long ids, as it generates these ids as it sees fit. ItemOperations doesn't have a folder id iirc so the handling of longids should be done exclusively in the backend IMHO.

[mschering]

OK thanks, I can add this in my backend. But is it ok to pass false to $folderId too?

[sebasi]

But is it ok to pass false to $folderId too?

I would say so, yes. That's by design. The longid is self contained. The backend should be able to uniquely identify a message of the user just with this id.
The spec gives some good ideas too: https://learn.microsoft.com/en-us/openspecs/exchange_server_protocols/ms-ascmd/552f41c0-33ff-48ab-9fd0-92239e0577f0