Skip to content

fixed find problem on ios 18. It searched for a message without a fol… #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mschering
Copy link
Contributor

@mschering mschering commented May 15, 2025

What does this implement/fix? Explain your changes.

This pull request replaces my old pull request implementing the Find command. I took the base code and tested it but ran into an issue:

The Find command implementation:

$message = self::$backend->Fetch(false, $u['longid'], $cpo);

Didn't pass the folderId to the backend Fetch() method:

public function Fetch($folderid, $id, $contentparameters) {

The message can't be found that way. I also pass the server ID and not the long ID as kopano is the only backend that splits the long ID:

list($fsk, $sk) = Utils::SplitMessageId($id);

The BackendDiff class doesn't do this.

Does this close any currently open issues?

Not sure. But it might close #141

Any relevant logs, error output, etc?

...

Where has this been tested?

Server (please complete the following information):

  • OS: debian
  • PHP Version: 8.3
  • Backend for: Group-Office
  • and Version: current development branch

Smartphone (please complete the following information):

  • Device: iPhone 13
  • OS: iOS 18
  • Mail App Apple mail

@mschering
Copy link
Contributor Author

I wanted to create a branch with this specific commit but it looks like it replaces the whole file. This is the commit I cherry picked to this branch:

Intermesh@229c56d

@mschering mschering closed this May 19, 2025
@mschering mschering deleted the find-fix branch May 19, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iPhone find not returning emails
1 participant