fixed find problem on ios 18. It searched for a message without a fol… #145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This pull request replaces my old pull request implementing the Find command. I took the base code and tested it but ran into an issue:
The Find command implementation:
Z-Push/src/lib/request/find.php
Line 178 in af25a21
Didn't pass the folderId to the backend Fetch() method:
Z-Push/src/lib/default/diffbackend/diffbackend.php
Line 129 in af25a21
The message can't be found that way. I also pass the server ID and not the long ID as kopano is the only backend that splits the long ID:
Z-Push/src/backend/kopano/kopano.php
Line 750 in 07f60c7
The BackendDiff class doesn't do this.
Does this close any currently open issues?
Not sure. But it might close #141
Any relevant logs, error output, etc?
...
Where has this been tested?
Server (please complete the following information):
Smartphone (please complete the following information):