Skip to content

Conversation

thijsoo
Copy link
Contributor

@thijsoo thijsoo commented Aug 28, 2025

Context

  • We want to add a unit test

Summary

This PR can be summarized in the following changelog entry:

  • Adds a unit test for the llms.txt health check.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • N/A

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@thijsoo thijsoo added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Aug 28, 2025
@coveralls
Copy link

coveralls commented Sep 1, 2025

Pull Request Test Coverage Report for Build 6af147e1132c0ec4c7a08552f951e6f71850163a

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 59 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.4%) to 52.894%

Files with Coverage Reduction New Missed Lines %
src/editors/framework/site/base-site-information.php 2 14.29%
inc/options/class-wpseo-options.php 3 39.89%
src/llms-txt/infrastructure/markdown-services/content-types-collector.php 4 78.57%
admin/tracking/class-tracking-settings-data.php 8 0.0%
src/llms-txt/domain/content-types/content-type-entry.php 12 50.0%
src/context/meta-tags-context.php 30 28.16%
Totals Coverage Status
Change from base Build 16e5640274e6ec9baf3c1ab2ae3d3edf7f82bd96: -0.4%
Covered Lines: 31239
Relevant Lines: 59386

💛 - Coveralls

Copy link
Contributor

@vraja-pro vraja-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove @Covers annotations from the methods. (That creates warnings when generating a report)

@vraja-pro vraja-pro added this to the 26.0 milestone Sep 3, 2025
Copy link
Contributor

@vraja-pro vraja-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✅

@vraja-pro vraja-pro merged commit bf02b89 into trunk Sep 3, 2025
26 checks passed
@vraja-pro vraja-pro deleted the 672-unit-tests-for-the-health-check branch September 3, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants